Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow envelopes #180

Merged
merged 4 commits into from
Apr 29, 2014
Merged

arrow envelopes #180

merged 4 commits into from
Apr 29, 2014

Conversation

jeffreyrosenbluth
Copy link
Member

I Think this may work, if so we can consider whether or not gaps should shorting the envelope of not.

@byorgey
Copy link
Member

byorgey commented Apr 28, 2014

I mean, this is fine as it goes, but is there really a big benefit to having an envelope corresponding to an imaginary straight arrow when the shaft is not straight?

@jeffreyrosenbluth
Copy link
Member Author

No the envelope does not correspond to a straight arrow, it's the actual arrow with a point head and tail

@byorgey
Copy link
Member

byorgey commented Apr 28, 2014

Oh, I see, I misunderstood. In that case, this is essentially equivalent to what the behavior used to be. The resulting envelope may be slightly wrong (potentially resulting in part of an arrow getting cut off at the edge of a diagram, etc.) since the actual position of the shaft depends on the head & tail size. We got rid of this, the reasoning being that it's much easier to explain that arrows have no envelope than it is to explain that diagrams have envelopes that may be slightly wrong.

jeffreyrosenbluth added a commit that referenced this pull request Apr 29, 2014
@jeffreyrosenbluth jeffreyrosenbluth merged commit 2ba5167 into master Apr 29, 2014
@jeffreyrosenbluth jeffreyrosenbluth deleted the arrow-env branch April 29, 2014 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants